-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Removal of note observer #4150
Conversation
🐙 OctomindTest Report: 0/14 successful.
commit sha: af66142 |
🐙 OctomindTest Report: 0/14 successful.
commit sha: 2e470a2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
🐙 OctomindTest Report: 0/14 successful.
commit sha: 2e470a2 |
🐙 OctomindTest Report: 0/14 successful.
commit sha: 2e470a2 |
🐙 OctomindTest Report: 0/14 successful.
commit sha: 2e470a2 |
🐙 OctomindTest Report: 0/14 successful.
commit sha: 2e470a2 |
The deployment to the dev cluster was successful. You can find the deployment here: https://4150.development.scrumlr.fra.ics.inovex.io Deployed Images
|
🐙 OctomindTest Report: 0/14 successful.
commit sha: 2e470a2 |
Co-authored-by: Benedict Homuth <bhomuth@inovex.de>
Description
This PR removes only the observers for notes. It is meant for a proof of concept before removing the remaining observers.
In order to test, I needed to mock the real-time broker (which includes its client aka. the con field).
Before I could not create a Mock-Broker, since the "con" field was not exported. With the changes at hand, I now export the "Con" field, which makes it possible to mock out the broker ultimately leading to running tests 🙂.
Changelog
Checklist
(Optional) Visual Changes