Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Removal of note observer #4150

Merged
merged 2 commits into from
May 21, 2024
Merged

chore: Removal of note observer #4150

merged 2 commits into from
May 21, 2024

Conversation

BenedictHomuth
Copy link
Collaborator

Description

This PR removes only the observers for notes. It is meant for a proof of concept before removing the remaining observers.

In order to test, I needed to mock the real-time broker (which includes its client aka. the con field).
Before I could not create a Mock-Broker, since the "con" field was not exported. With the changes at hand, I now export the "Con" field, which makes it possible to mock out the broker ultimately leading to running tests 🙂.

Changelog

  • Removed the note observers
  • Moved the observer logic inside the service layer
  • Made the general code work with those changes
  • Exported the Con field of real-time broker in order to be able to mock the real-time package
  • Adapted tests to run without observers

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • The light- and dark-theme are both supported and tested
  • The design was implemented and is responsive for all devices and screen sizes
  • The application was tested in the most commonly used browsers (e.g. Chrome, Firefox, Safari)

(Optional) Visual Changes

@BenedictHomuth BenedictHomuth self-assigned this May 17, 2024
@BenedictHomuth BenedictHomuth added the Review Needed This pull request is ready for review label May 17, 2024
Copy link

octomind-dev bot commented May 17, 2024

🐙 Octomind

Test Report: 0/14 successful.

description status details
About Section Visibility Test Failed ❌ click
change avatar Failed ❌ click
check Privacy Policy Failed ❌ click
check terms & conditions Failed ❌ click
close cookie banner - front page Failed ❌ click
close cookie banner - sign-in Failed ❌ click
create and delete board columns Failed ❌ click
create_and_delete_notes_and_actions_v2 Failed ❌ click
create lean coffee board Failed ❌ click
edit_notes_and_actions_v5 Failed ❌ click
get started Failed ❌ click
share_session Failed ❌ click
sign-in Failed ❌ click
test all ways to open the setup flow Failed ❌ click

commit sha: af66142

Copy link

octomind-dev bot commented May 17, 2024

🐙 Octomind

Test Report: 0/14 successful.

description status details
About Section Visibility Test Failed ❌ click
change avatar Failed ❌ click
check Privacy Policy Failed ❌ click
check terms & conditions Failed ❌ click
close cookie banner - front page Failed ❌ click
close cookie banner - sign-in Failed ❌ click
create and delete board columns Failed ❌ click
create_and_delete_notes_and_actions_v2 Failed ❌ click
create lean coffee board Failed ❌ click
edit_notes_and_actions_v5 Failed ❌ click
get started Failed ❌ click
share_session Failed ❌ click
sign-in Failed ❌ click
test all ways to open the setup flow Failed ❌ click

commit sha: 2e470a2

Copy link
Collaborator

@mateo-ivc mateo-ivc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

octomind-dev bot commented May 17, 2024

🐙 Octomind

Test Report: 0/14 successful.

description status details
About Section Visibility Test Failed ❌ click
change avatar Failed ❌ click
check Privacy Policy Failed ❌ click
check terms & conditions Failed ❌ click
close cookie banner - front page Failed ❌ click
close cookie banner - sign-in Failed ❌ click
create and delete board columns Failed ❌ click
create_and_delete_notes_and_actions_v2 Failed ❌ click
create lean coffee board Failed ❌ click
edit_notes_and_actions_v5 Failed ❌ click
get started Failed ❌ click
share_session Failed ❌ click
sign-in Failed ❌ click
test all ways to open the setup flow Failed ❌ click

commit sha: 2e470a2

Copy link

octomind-dev bot commented May 17, 2024

🐙 Octomind

Test Report: 0/14 successful.

description status details
About Section Visibility Test Failed ❌ click
change avatar Failed ❌ click
check Privacy Policy Failed ❌ click
check terms & conditions Failed ❌ click
close cookie banner - front page Failed ❌ click
close cookie banner - sign-in Failed ❌ click
create and delete board columns Failed ❌ click
create_and_delete_notes_and_actions_v2 Failed ❌ click
create lean coffee board Failed ❌ click
edit_notes_and_actions_v5 Failed ❌ click
get started Failed ❌ click
share_session Failed ❌ click
sign-in Failed ❌ click
test all ways to open the setup flow Failed ❌ click

commit sha: 2e470a2

Copy link

octomind-dev bot commented May 17, 2024

🐙 Octomind

Test Report: 0/14 successful.

description status details
About Section Visibility Test Failed ❌ click
change avatar Failed ❌ click
check Privacy Policy Failed ❌ click
check terms & conditions Failed ❌ click
close cookie banner - front page Failed ❌ click
close cookie banner - sign-in Failed ❌ click
create and delete board columns Failed ❌ click
create_and_delete_notes_and_actions_v2 Failed ❌ click
create lean coffee board Failed ❌ click
edit_notes_and_actions_v5 Failed ❌ click
get started Failed ❌ click
share_session Failed ❌ click
sign-in Failed ❌ click
test all ways to open the setup flow Failed ❌ click

commit sha: 2e470a2

Copy link

octomind-dev bot commented May 20, 2024

🐙 Octomind

Test Report: 0/14 successful.

description status details
About Section Visibility Test Failed ❌ click
change avatar Failed ❌ click
check Privacy Policy Failed ❌ click
check terms & conditions Failed ❌ click
close cookie banner - front page Failed ❌ click
close cookie banner - sign-in Failed ❌ click
create and delete board columns Failed ❌ click
create_and_delete_notes_and_actions_v2 Failed ❌ click
create lean coffee board Failed ❌ click
edit_notes_and_actions_v5 Failed ❌ click
get started Failed ❌ click
share_session Failed ❌ click
sign-in Failed ❌ click
test all ways to open the setup flow Failed ❌ click

commit sha: 2e470a2

Copy link

The deployment to the dev cluster was successful. You can find the deployment here: https://4150.development.scrumlr.fra.ics.inovex.io
This deployment is only for testing purposes and will be deleted after 1 week.
To redeploy rerun the workflow.
DO NOT STORE IMPORTANT DATA ON THIS DEPLOYMENT

Deployed Images
  • ghcr.io/inovex/scrumlr.io/scrumlr-frontend:sha-2e470a2

  • ghcr.io/inovex/scrumlr.io/scrumlr-server:sha-2e470a2

Copy link

octomind-dev bot commented May 21, 2024

🐙 Octomind

Test Report: 0/14 successful.

description status details
About Section Visibility Test Failed ❌ click
change avatar Failed ❌ click
check Privacy Policy Failed ❌ click
check terms & conditions Failed ❌ click
close cookie banner - front page Failed ❌ click
close cookie banner - sign-in Failed ❌ click
create and delete board columns Failed ❌ click
create_and_delete_notes_and_actions_v2 Failed ❌ click
create lean coffee board Failed ❌ click
edit_notes_and_actions_v5 Failed ❌ click
get started Failed ❌ click
share_session Failed ❌ click
sign-in Failed ❌ click
test all ways to open the setup flow Failed ❌ click

commit sha: 2e470a2

@BenedictHomuth BenedictHomuth added this pull request to the merge queue May 21, 2024
Merged via the queue into main with commit 45f2b40 May 21, 2024
6 checks passed
@BenedictHomuth BenedictHomuth deleted the bh/note-observer branch May 21, 2024 15:45
Lennart01 pushed a commit that referenced this pull request Jun 17, 2024
Co-authored-by: Benedict Homuth <bhomuth@inovex.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review Needed This pull request is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants