Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: removal of board service observer #4160

Merged
merged 8 commits into from
Jun 18, 2024

Conversation

BenedictHomuth
Copy link
Collaborator

@BenedictHomuth BenedictHomuth commented May 22, 2024

Description

This PR removes the observers for the board service.

Changelog

  • moved observer logic into service layer
  • added logging to before unlogged errors

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • The light- and dark-theme are both supported and tested
  • The design was implemented and is responsive for all devices and screen sizes
  • The application was tested in the most commonly used browsers (e.g. Chrome, Firefox, Safari)

@BenedictHomuth BenedictHomuth self-assigned this May 22, 2024
Copy link

octomind-dev bot commented May 22, 2024

🐙 Octomind

Test Report: 0/14 successful.

description status details
About Section Visibility Test Failed ❌ click
change avatar Failed ❌ click
check Privacy Policy Failed ❌ click
check terms & conditions Failed ❌ click
close cookie banner - front page Failed ❌ click
close cookie banner - sign-in Failed ❌ click
create and delete board columns Failed ❌ click
create_and_delete_notes_and_actions_v2 Failed ❌ click
create lean coffee board Failed ❌ click
edit_notes_and_actions_v5 Failed ❌ click
get started Failed ❌ click
share_session Failed ❌ click
sign-in Failed ❌ click
test all ways to open the setup flow Failed ❌ click

commit sha: a575f11

Copy link

The deployment to the dev cluster was successful. You can find the deployment here: https://4160.development.scrumlr.fra.ics.inovex.io
This deployment is only for testing purposes and will be deleted after 1 week.
To redeploy rerun the workflow.
DO NOT STORE IMPORTANT DATA ON THIS DEPLOYMENT

Deployed Images
  • ghcr.io/inovex/scrumlr.io/scrumlr-frontend:sha-c23a09b

  • ghcr.io/inovex/scrumlr.io/scrumlr-server:sha-c23a09b

Copy link

octomind-dev bot commented May 24, 2024

🐙 Octomind

Test Report: 0/14 successful.

description status details
About Section Visibility Test Failed ❌ click
change avatar Failed ❌ click
check Privacy Policy Failed ❌ click
check terms & conditions Failed ❌ click
close cookie banner - front page Failed ❌ click
close cookie banner - sign-in Failed ❌ click
create and delete board columns Failed ❌ click
create_and_delete_notes_and_actions_v2 Failed ❌ click
create lean coffee board Failed ❌ click
edit_notes_and_actions_v5 Failed ❌ click
get started Failed ❌ click
share_session Failed ❌ click
sign-in Failed ❌ click
test all ways to open the setup flow Failed ❌ click

commit sha: c23a09b

Copy link
Collaborator

@mateo-ivc mateo-ivc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far

@BenedictHomuth BenedictHomuth added this pull request to the merge queue Jun 3, 2024
@BenedictHomuth BenedictHomuth removed this pull request from the merge queue due to a manual request Jun 3, 2024
@BenedictHomuth BenedictHomuth added this pull request to the merge queue Jun 18, 2024
Merged via the queue into main with commit 68bf785 Jun 18, 2024
5 of 6 checks passed
@BenedictHomuth BenedictHomuth deleted the bh/removal-column-observer branch June 18, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants