Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hidden columns not showing after promotion to moderator #4234

Merged
merged 4 commits into from
Jun 19, 2024

Conversation

BenedictHomuth
Copy link
Collaborator

@BenedictHomuth BenedictHomuth commented Jun 18, 2024

Description

Whenever someone gets promoted to moderator, he/she should be able to see the hidden columns. This is now possible since we sync columns (ColumnsUpdated) on a ParticipantUpdated event.

Before, this call was not present resulting in a situation where the newly named moderator needed to refresh the page to finally see the hidden columns.

Since #4179 has broadened the scope of a BoardSession DTO – specifically the AccountType – I needed to extend our DB calls, since when I parse the event in the EventFilter, it errors, since AccountType can not be an empty string (at least for now).

Therefore we should check and decide, if we want to publish the AccountType information or not. If not, I can also just annotate the AccountType in the DTO with "omitempty".

Changelog

  • added the accounttype to our db calls
  • added caching to board participants in the event filter
  • added the column refresh for when a participant got updated.

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • The light- and dark-theme are both supported and tested
  • The design was implemented and is responsive for all devices and screen sizes
  • The application was tested in the most commonly used browsers (e.g. Chrome, Firefox, Safari)

(Optional) Visual Changes

@BenedictHomuth BenedictHomuth self-assigned this Jun 18, 2024

This comment has been minimized.

@BenedictHomuth BenedictHomuth added the Review Needed This pull request is ready for review label Jun 18, 2024
Copy link
Collaborator

@Schwehn42 Schwehn42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Therefore we should check and decide, if we want to publish the AccountType information or not. If not, I can also just annotate the AccountType in the DTO with "omitempty".

AccountType is required for #4229, does this have an impact on it?

@BenedictHomuth
Copy link
Collaborator Author

Therefore we should check and decide, if we want to publish the AccountType information or not. If not, I can also just annotate the AccountType in the DTO with "omitempty".

AccountType is required for #4229, does this have an impact on it?

If I see it correctly, the information of AccountType is planned to be available in the frontend. Therefore I would suggest keeping this PR as is, since with the changes present in this PR the AccountType is now published – at least from a backend perspective.

Copy link

The deployment to the dev cluster was successful. You can find the deployment here: https://4234.development.scrumlr.fra.ics.inovex.io
This deployment is only for testing purposes and will be deleted after 1 week.
To redeploy rerun the workflow.
DO NOT STORE IMPORTANT DATA ON THIS DEPLOYMENT

Deployed Images
  • ghcr.io/inovex/scrumlr.io/scrumlr-frontend:sha-a2c65b1

  • ghcr.io/inovex/scrumlr.io/scrumlr-server:sha-a2c65b1

Copy link

octomind-dev bot commented Jun 19, 2024

🐙 Octomind

Test Report: 13/14 successful.

description status details
About Section Visibility Test Passed ✅ click
change avatar Passed ✅ click
check Privacy Policy Passed ✅ click
check terms & conditions Passed ✅ click
close cookie banner - front page Passed ✅ click
close cookie banner - sign-in Passed ✅ click
create and delete board columns Passed ✅ click
create_and_delete_notes_and_actions_v2 Passed ✅ click
create lean coffee board Passed ✅ click
edit_notes_and_actions_v5 Passed ✅ click
get started Passed ✅ click
share_session Passed ✅ click
sign-in Passed ✅ click
test all ways to open the setup flow Failed ❌ click

commit sha: a2c65b1

Copy link
Collaborator

@mateo-ivc mateo-ivc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@BenedictHomuth BenedictHomuth added this pull request to the merge queue Jun 19, 2024
Merged via the queue into main with commit b4c424a Jun 19, 2024
8 checks passed
@BenedictHomuth BenedictHomuth deleted the bh/fix-column-sync branch June 19, 2024 12:13
BenedictHomuth added a commit that referenced this pull request Jun 27, 2024
Co-authored-by: Benedict Homuth <bhomuth@inovex.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review Needed This pull request is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants