Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: removal of database observer #4235

Merged
merged 1 commit into from
Jun 19, 2024
Merged

Conversation

BenedictHomuth
Copy link
Collaborator

Description

This PR removes the last bits of our former observers.

Changelog

  • deleted last references and tests from former observers

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • The light- and dark-theme are both supported and tested
  • The design was implemented and is responsive for all devices and screen sizes
  • The application was tested in the most commonly used browsers (e.g. Chrome, Firefox, Safari)

(Optional) Visual Changes

@BenedictHomuth BenedictHomuth self-assigned this Jun 18, 2024
@BenedictHomuth BenedictHomuth linked an issue Jun 18, 2024 that may be closed by this pull request
@BenedictHomuth BenedictHomuth added the Review Needed This pull request is ready for review label Jun 18, 2024
Copy link

The deployment to the dev cluster was successful. You can find the deployment here: https://4235.development.scrumlr.fra.ics.inovex.io
This deployment is only for testing purposes and will be deleted after 1 week.
To redeploy rerun the workflow.
DO NOT STORE IMPORTANT DATA ON THIS DEPLOYMENT

Deployed Images
  • ghcr.io/inovex/scrumlr.io/scrumlr-frontend:sha-8b72234

  • ghcr.io/inovex/scrumlr.io/scrumlr-server:sha-8b72234

Copy link

octomind-dev bot commented Jun 18, 2024

🐙 Octomind

Test Report: 6/14 successful.

description status details
About Section Visibility Test Passed ✅ click
change avatar Failed ❌ click
check Privacy Policy Passed ✅ click
check terms & conditions Passed ✅ click
close cookie banner - front page Passed ✅ click
close cookie banner - sign-in Passed ✅ click
create and delete board columns Failed ❌ click
create_and_delete_notes_and_actions_v2 Failed ❌ click
create lean coffee board Failed ❌ click
edit_notes_and_actions_v5 Failed ❌ click
get started Passed ✅ click
share_session Failed ❌ click
sign-in Failed ❌ click
test all ways to open the setup flow Failed ❌ click

commit sha: 8b72234

Copy link
Collaborator

@mateo-ivc mateo-ivc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍🏽

@BenedictHomuth BenedictHomuth added this pull request to the merge queue Jun 19, 2024
Merged via the queue into main with commit bcf3d2f Jun 19, 2024
8 checks passed
@BenedictHomuth BenedictHomuth deleted the bh/remove-database-observer branch June 19, 2024 08:26
BenedictHomuth added a commit that referenced this pull request Jun 27, 2024
Co-authored-by: Benedict Homuth <bhomuth@inovex.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review Needed This pull request is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace observers by integration into services
2 participants