Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ssi-modal.js): update keymap #20

Merged
merged 13 commits into from Feb 1, 2023
Merged

Conversation

bhsd-harry
Copy link
Member

lib/ssi-modal/ssi-modal.js Outdated Show resolved Hide resolved
lib/ssi-modal/ssi-modal.js Outdated Show resolved Hide resolved
@dragon-fish
Copy link
Member

我理解一下这个PR所做的修改:

  1. 为 confirm 的确认取消添加了快捷键
  2. 修改了快捷键的逻辑,使快捷键按下时一定作用于最后打开的模态框,以便IPE能够使用ctrl-s进行保存

是这个意思吗

@bhsd-harry
Copy link
Member Author

bhsd-harry commented Mar 12, 2022

  1. 增加一种快捷键作用机制。以前的机制为只要在页面任意位置按下快捷键,则所有绑定该快捷键的模态框都会生效;现在这种机制需要额外设置 keyPressBody: true 。新增一种机制作为默认,快捷键只对当前 focus 的模态框生效。

  2. 支持组合快捷键,如 Ctrl、Command、Alt、Shift 等。

  3. 对图标型按钮添加了快捷键支持。

  4. 给所有 confirm 模态框预设添加页面任意位置 Enter 键确认。

Copy link
Member

@dragon-fish dragon-fish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

机智的小鱼君@moegirl 22:25:47
Plugins#20怎么办,不想看了,直接合吧,有问题再revert

Bhsd@LLWiki 22:25:59
好。

@bhsd-harry bhsd-harry merged commit 56dde7a into inpageedit:master Feb 1, 2023
@bhsd-harry bhsd-harry deleted the master branch February 1, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants