Skip to content
This repository has been archived by the owner on Sep 2, 2021. It is now read-only.

Chinese Language can't be set #232

Closed
mahmoudkhalafallah opened this issue Sep 18, 2016 · 4 comments
Closed

Chinese Language can't be set #232

mahmoudkhalafallah opened this issue Sep 18, 2016 · 4 comments

Comments

@mahmoudkhalafallah
Copy link

Version Information

  • WordPress: 4.5
  • MultilingualPress: 2.4.7

Steps to Reproduce

  1. add 2 sites the first is in English, and the Second has to be in Chinese.
  2. while trying to add the Chinese version of your site, click save and wait for page reload.

What I Expected

The site language to be Chinese.

What Happened Instead

The site language is Chinese Singapore instead of Chinese.
as shown in the screenshot the value attribute sent from the select element is the same for both Chinese and Chinese Singapore (zh).

Screenshot or Video

multilingualpress-bug

@tfrommen
Copy link
Member

Hi there,

I just checked this, and yes, the entry for Chinese (Singapore) is incorrect (and has the same HTTP code as Chinese). We will fix this in a future release.

To get your site running right now, you can edit the language in the Language Manager (to be found at /wp-admin/network/settings.php?page=language-manager). Find Chinese (Singapore), edit the HTTP code to be zh-SG, and save the change.

Best regards,
Thorsten

@tfrommen tfrommen mentioned this issue Sep 20, 2016
@mahmoudkhalafallah
Copy link
Author

Ok, thank you

@tfrommen
Copy link
Member

Has been fixed for master in 49d2d92.

@tfrommen tfrommen added this to the v2.4.8 milestone Oct 11, 2016
@tfrommen tfrommen self-assigned this Oct 11, 2016
@tfrommen
Copy link
Member

Closed with 43f64b1.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants