Skip to content
This repository has been archived by the owner on Sep 2, 2021. It is now read-only.

Media Library Grid View JS issue #249

Closed
luisarn opened this issue Jan 16, 2017 · 3 comments
Closed

Media Library Grid View JS issue #249

luisarn opened this issue Jan 16, 2017 · 3 comments
Assignees
Milestone

Comments

@luisarn
Copy link

luisarn commented Jan 16, 2017

  • WordPress: 4.7.1
  • MultilingualPress: 2.5.0
  1. Enable Multilingual Press
  2. Go to Media Library
  3. Switch to Grid View

3rd party plugins that relies on Javascript stops working.
Seems the JS loaded again when entering Grid View (check console):

Uncaught Error: Backbone.history has already been started

@tfrommen
Copy link
Member

Hi @luisarn,

thanks for reporting.

I had a look at it, and it seems this is an issue with WordPress core. I just created a ticket on Trac.

Regarding MultilingualPress: by default, there shouldn't be any MLP JavaScript running on Media. A quick fix would therefore be to find out why admin.js is enqueued, and undo that (taking care of all modules still being functional on their individual pages, of course).

I will look into this within the next two weeks or so.

Cheers,
Thorsten

@tfrommen
Copy link
Member

tfrommen commented Feb 1, 2017

Hi @luisarn,

while my Trac ticket is waiting to get merged (and eventually released), I fixed the asset loading in MLP.

If that is possible, you can try the new branch. Ideal result: the MLP JavaScript is working where it should, and you can use the Media page. :)

@tfrommen
Copy link
Member

tfrommen commented Feb 3, 2017

Fixed in MultilingualPress v2.5.1.

@tfrommen tfrommen closed this as completed Feb 3, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants