Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request]: Bump squizlabs/php_codesniffer #57

Closed
1 task done
thefrosty opened this issue Sep 15, 2022 · 1 comment · Fixed by #69
Closed
1 task done

[Feature Request]: Bump squizlabs/php_codesniffer #57

thefrosty opened this issue Sep 15, 2022 · 1 comment · Fixed by #69
Assignees
@gmazzap
Labels
enhancement
Milestone
v2.0.0

Comments

@thefrosty
Copy link

Is your feature request related to a problem?

Can't update/install over PHPCS standards that require latest php_codesniffer version.

Describe the desired solution

Currently squizlabs/php_codesniffer is locked at ~3.6.0, but now suggests 3.* or latest is now 3.7.1.

Describe the alternatives that you have considered

??

Additional context

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
gmazzap added a commit that referenced this issue Sep 15, 2022
@gmazzap
Lock on major for PHPCS
6d7f5ab 
see #57
@gmazzap gmazzap self-assigned this Sep 15, 2022
@gmazzap
Copy link
Contributor

gmazzap commented Sep 19, 2022

Hi @thefrosty, thank you.

This is done in master with #6d7f5ab and will be added to next release.

@gmazzap gmazzap mentioned this issue Aug 25, 2023
Merged
3 tasks
@gmazzap gmazzap added this to the v2.0.0 milestone Aug 25, 2023
@Chrico Chrico linked a pull request Aug 28, 2023 that will close this issue
[In Progress] Modernize to PHP 8 WPCS 3 #69
Merged
3 tasks
@gmazzap gmazzap closed this as completed Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gmazzap gmazzap

Labels
enhancement
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging a pull request may close this issue.

[In Progress] Modernize to PHP 8 WPCS 3 inpsyde/php-coding-standards
2 participants
@thefrosty @gmazzap