-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get rid of Neutron PHP Standard #70
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added custom DisableCallUserFuncSniff (with tests) - Added custom DisableMagicSerializeSniff (with tests) - Added custom NoRootNamespaceFunctionsSniff (with tests) - Added Slevomat standard as dependency - Explicilty required PHPCSExtra and PHPCS Utils - Replaced some Netron sniffs with Generic/Squid/PHPCSExtra/Slevomat - Renamed updated WPCS standards - Improved QA
1 task
1 task
1 task
tfrommen
reviewed
Aug 30, 2023
Co-authored-by: Thorsten Frommen <info@tfrommen.de> Signed-off-by: Giuseppe Mazzapica <giuseppe.mazzapica@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All fine for me, just noticed a very little thing that could be added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature
What is the current behavior? (You can also link to an open issue here)
See #65
What is the new behavior (if this is a feature change)?
DisableCallUserFuncSniff
(with tests)DisableMagicSerializeSniff
(with tests)NoRootNamespaceFunctionsSniff
(with tests)Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Yes. Any configuration or ignore/disable comments referring Neutron standard will break
Other information: