Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of Neutron PHP Standard #70

Merged
merged 7 commits into from
Aug 31, 2023
Merged

Get rid of Neutron PHP Standard #70

merged 7 commits into from
Aug 31, 2023

Conversation

gmazzap
Copy link
Contributor

@gmazzap gmazzap commented Aug 30, 2023

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Feature

What is the current behavior? (You can also link to an open issue here)

See #65

What is the new behavior (if this is a feature change)?

  • Added custom DisableCallUserFuncSniff (with tests)
  • Added custom DisableMagicSerializeSniff (with tests)
  • Added custom NoRootNamespaceFunctionsSniff (with tests)
  • Added Slevomat standard as dependency
  • Explicilty required PHPCSExtra and PHPCS Utils
  • Replaced some Neutron sniffs with Generic/Squid/PHPCSExtra/Slevomat
  • Renamed updated WPCS standards
  • Improved QA

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Yes. Any configuration or ignore/disable comments referring Neutron standard will break

Other information:

- Added custom DisableCallUserFuncSniff (with tests)
- Added custom DisableMagicSerializeSniff (with tests)
- Added custom NoRootNamespaceFunctionsSniff (with tests)
- Added Slevomat standard as dependency
- Explicilty required PHPCSExtra and PHPCS Utils
- Replaced some Netron sniffs with Generic/Squid/PHPCSExtra/Slevomat
- Renamed updated WPCS standards
- Improved QA
gmazzap and others added 2 commits August 30, 2023 23:43
Co-authored-by: Thorsten Frommen <info@tfrommen.de>
Signed-off-by: Giuseppe Mazzapica <giuseppe.mazzapica@gmail.com>
Copy link
Contributor

@antonioeatgoat antonioeatgoat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All fine for me, just noticed a very little thing that could be added.

tests/fixtures/disallow-magic-serialize.php Show resolved Hide resolved
@gmazzap gmazzap merged commit 91f94c9 into version/2 Aug 31, 2023
10 checks passed
@tfrommen tfrommen deleted the feature/65 branch August 31, 2023 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Get rid of Neutron PHP Standard
3 participants