Allow customizing package manager #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyrann0us
reviewed
Jan 11, 2023
This is part of the PR following the pathfinder rules.
tyrann0us
reviewed
Jan 24, 2023
There was a problem hiding this comment.
Thanks for incorporating the changes! While going through build-and-push-assets.yml, I realized that this workflow auto-detects the package manager. IMO, this is great because it saves us from having to specify the package manager in every calling workflow. Can you please update this PR to use the auto-detection as well? Thanks!
# Conflicts: # .github/workflows/build-and-push-assets.yml # docs/build-and-push-assets.md
Chrico
approved these changes
Mar 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature.
What is the current behavior? (You can also link to an open issue here)
It's not possible to select a package manager to install dependencies for QA workflows.
Yarn and npm definitely go in a different ways to provide specific functionality so it will be nice to run QA with the same package manager as locally. And install dependencies from the related
.lockfile if it exists.What is the new behavior (if this is a feature change)?
Add
PACKAGE_MANAGERinput and related functionality. Essentially code was picked from theBuild and push assetsworkflow (without autodetection).Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No. Because by default is
npmas it is now.Other information: