Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Dry Run option #60

Closed
wants to merge 3 commits into from
Closed

Introduce Dry Run option #60

wants to merge 3 commits into from

Conversation

widoz
Copy link
Member

@widoz widoz commented Aug 14, 2023

Allow third parties to perform a compilation without committing or pushing the assets.

This is useful in a CI context when in a PR you need to compile the assets to prevent wrong changes to affect the target branch.

An example for a possible configuration is DRY_RUN: ${{ github.event_name != 'pull_request' }}


Let's assume your colleague made a PR, the PR includes changes in some .ts|.tsx files. The action is not running in the PR but only in the target branch and only after the merge.

It might happen that after the merge the compilation of the assets failed, now you have a broken build.

To prevent that, we would like to run the assets compilation in the PR but the branch associated to the PR does not need to get the assets updated since them will be compiled when the PR will be merged.

Having the dry-run option ON will allow us to run the compilation as part of the CI of the PR to ensure the changes are not impacting negatively the project. Nonetheless we do not want to commit and push the assets in the branch but only when the PR is merged, hence in the target branch.

It is the target branch responsible to commit and push the assets to avoid conflicts and problems.

@widoz widoz requested review from tyrann0us, Chrico and gmazzap and removed request for tyrann0us August 14, 2023 12:01
@widoz
Copy link
Member Author

widoz commented Aug 16, 2023

Closing in favor of #63

@widoz widoz closed this Aug 16, 2023
@widoz widoz deleted the feature/dry-run branch August 16, 2023 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant