Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracker issue: Drag and Drop. #855

Open
ghost opened this issue Nov 4, 2021 · 7 comments
Open

Tracker issue: Drag and Drop. #855

ghost opened this issue Nov 4, 2021 · 7 comments
Labels
barrier-import Imported from Barrier - likely outdated. bsd/freebsd Bugs affecting FreeBSD.. enhancement New feature or request help-wanted Extra attention is needed meta Related to the management of the repository/organisation platform/linux This issue is affecting at least one system running Linux platform/macOS This issue is affecting at least one system running macOS platform/windows This issue is affecting at least one system running Windows

Comments

@ghost
Copy link

ghost commented Nov 4, 2021

This issue has been migrated from old Barrier Github repository debauchee/barrier#855

Issue created on: 2020-08-28 by @shymega
Issue last updated on: 2021-10-14

Due to the numerous issues created, without any sign of checking for duplicate issues, I have taken this opportunity to close those issues about drag and drop not working in favour of a centralised tracking issue.

Please only comment on this issue with constructive and positive messages that will facilitate the development and maintenance of drag and drop support. Unconstructive messages will be removed if they do not fit the discussion. Reacting to messages is fine, however, as it indicates the general feeling towards construction and maintenance of drag and drop.

Thank you 😄


Commented on: 2020-08-28 by @shymega

On the note of reactions, could those with this issue, please react to this comment with 👍 (:+1). Thanks. This will allow us to gauge the spread of the issue.


Commented on: 2020-09-14 by @chrishultberg

Using Ubuntu 18.04.3 LTS as the server and Windows 10 Pro as the client, I can not drag and drop files.
This also means that I can't copy/paste the files...

Doesn't seem like there's been an update to this in a few weeks so I wanted to double-check.


Commented on: 2020-09-15 by @shymega

You don't need to double-check. If the issue hasn't been updated, please assume nothing has changed. Which it hasn't. I only say this so the tracker issue doesn't get "noisy" with comments asking if there's been any progress etc....


Commented on: 2020-11-27 by @arthur-tacca

Personally, I would prefer a file transfer that was very clunky (even just pasting the source and destination filenames into text boxes) but worked, rather than something with a smooth interface (like drag and drop) but is unreliable. This is especially the case with Linux - I don't believe drag and drop is even intended to work on Linux but Linux-Windows is my primary use case, so anything at all would be a great help with that.

(Apologies for commenting on this high-activity thread but I think this is genuinely new content. Those that agree/disagree with my preference had add their reactions accordingly to this comment.)


Commented on: 2021-05-22 by @shymega

All - this is a tracking issue for the development of this feature. Please only comment constructively. I'm going to delete those comments that merely post logs etc of the current behaviour. I recognise my decision may be controversial, but we really need to keep the issue constructive. Thank you.


Commented on: 2021-05-23 by @shymega

Personally, I would prefer a file transfer that was very clunky (even just pasting the source and destination filenames into text boxes) but worked, rather than something with a smooth interface (like drag and drop) but is unreliable. This is especially the case with Linux - I don't believe drag and drop is even intended to work on Linux but Linux-Windows is my primary use case, so anything at all would be a great help with that.

(Apologies for commenting on this high-activity thread but I think this is genuinely new content. Those that agree/disagree with my preference had add their reactions accordingly to this comment.)

By the way, I know this is a late reply, but thank you for your comment - I think we should bear this in mind for the implementation, as and when. Definitely valuable content, thank you!


Commented on: 2021-08-22 by @ussu99

I'm using following Combination of Machines:

  • iMac (Mac OS Big Sur) with Barrier Server Version 2.3.3
  • Macbook Pro (Mac OS Big Sur) with Barrier Client Version 2.3.3 Release
  • windows 10 laptop (21H1) with Barrier Client Version 2.3.3 Release

Summary What Works what not

  1. Drag And Drop between Mac Os does work
  2. Drag And Drop from Mac OS to Windows 10 doest not work.
**Mac OS Log**
2021-08-22 20:50:44.998931+0200 barriers[888:26853] [sandbox] Failed to get a sandbox extension
[2021-08-22T20:50:45] INFO: switch from "Macos" to "Windows10" at 0,721
[2021-08-22T20:50:45] INFO: leaving screen

**Windows Log**
[2021-08-22T20:50:46] DEBUG: drag info received, total drag file number: 1
[2021-08-22T20:50:46] DEBUG: dragging file 1 name: Testxml.xml
[2021-08-22T20:50:46] INFO: entering screen
[2021-08-22T20:50:56] INFO: found key in group 0 
  1. Drag An Drop from Windows 10 to Mac Os doest not work
**Windows10 Log**
DEBUG: failed to get drag file name from OLE
**MacOS  Log**
[2021-08-22T20:53:18] INFO: switch from "Windows10" to "Macos" at 2554,590
[2021-08-22T20:53:18] INFO: entering screen
  1. Clipboard Transfer Does Work between all Machines

Commented on: 2021-08-23 by @baldyman01

Drag and drop does not work at all on Ubuntu 20.04. If this is the central tracking issue for drag and drop and the last actual status update was "If the issue hasn't been updated, please assume nothing has changed. Which it hasn't." and this was back in Sept 2020, can we now assume that this feature will never happen and is being removed from the feature list of the program?


Commented on: 2021-08-23 by @shymega

No, it will happen, but we just don't have enough devs or manpower yet. Again, assume nothing has changed...


Commented on: 2021-09-07 by @mblend27

How can I help make this happen? I have $ and don't like any other software out there. If me throwing $ at you isnt constructive... del this ;)


Commented on: 2021-09-08 by @shymega

Still no update, but we will consider the suggestion of monetary contributions towards the goal. I don't think it will be a straightforward fix, however, and we have a fair few critical issues to go through.


Commented on: 2021-10-14 by @Carocrazy132

First off as a side note I find it odd that this was merged with the clipboard issues.

I'm running Macmini 9,1 with macOS 11.6 (20G165) for the client, Windows 10 Pro 10.0.19043 Build 19043 as the server, and the clipboard will only successfully copy from client to server, but never from server to client. The client logs do note that the clipboard was updated (though only sometimes, and there are two prints) but it seems the clipboard is only cleared when this happens.

@ghost ghost added bsd/freebsd Bugs affecting FreeBSD.. bsd/openbsd enhancement New feature or request help-wanted Extra attention is needed platform/linux This issue is affecting at least one system running Linux platform/macOS This issue is affecting at least one system running macOS meta Related to the management of the repository/organisation platform/windows This issue is affecting at least one system running Windows labels Nov 10, 2021
This was referenced Nov 10, 2021
@ashvinnihalani
Copy link

I want to get started on this but am unsure where to start. I am also not too familiar with how Windows works behind the hood. However, lets get the discussion open on this so we at least know where to start working.

@ashvinnihalani
Copy link

So my understanding of the problem is that Windows/Mac/Linux all handle the drag/dropping behind the hood. I found some articles about how windows handle the drag and drop here: https://docs.microsoft.com/en-us/windows/apps/design/input/drag-and-drop
Linux has a variety of Clipboard managers but it is my understanding that selecting a file selects the location of the file and then when you paste it the system assumes you want to paste a file and copies the file over

@ashvinnihalani
Copy link

In that vein, a good POC implementation might be able to move files using the CTRL+V and CTRL+C commands and try to get the actual drag and drop working later. My follow-up question how does input-leap handle a connection between computers, it is a straight ssh connection or something different and where are the files that refer to it. A list of relevant files would be super helpful if someone has the time

@muscarina
Copy link

Seems like someone found a solution to this, but only posted it in the barrier repo:

@shymega
Copy link
Member

shymega commented Jun 2, 2023

I've just replied, might be best for them to post in the wiki-prs repo on this org.

@Viliansh
Copy link

Viliansh commented Sep 22, 2023

maybe this can be helpful electron/electron#30650 for linux, portal works both xorg and wayland, so it a "future proof" solution

@shymega
Copy link
Member

shymega commented Sep 24, 2023

Yes, that's an option. I think supporting XDG portals is the future, but we need to consider BSD/macOS, too. I'm wondering if an abstracted class over 'backends' for clipboards might work well.

@shymega shymega added the barrier-import Imported from Barrier - likely outdated. label Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
barrier-import Imported from Barrier - likely outdated. bsd/freebsd Bugs affecting FreeBSD.. enhancement New feature or request help-wanted Extra attention is needed meta Related to the management of the repository/organisation platform/linux This issue is affecting at least one system running Linux platform/macOS This issue is affecting at least one system running macOS platform/windows This issue is affecting at least one system running Windows
Projects
None yet
Development

No branches or pull requests

4 participants