Handling some minor comments on the SECP changes #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iquerejeta
force-pushed
the
iquerejeta/audit-comments
branch
from
ccc3e59
to
72cca44
Compare
lehins
approved these changes
Oct 4, 2022
There was a problem hiding this comment.
@iquerejeta Thank you for picking up where @kozross left it.
Few minor improvements I'd like to suggest listed in comments as well as clearing out trailing whitespaces (see CI)
Co-authored-by: Alexey Kuleshevich <alexey.kuleshevich@iohk.io>
nfrisby
added a commit
that referenced
this pull request
Nov 22, 2022
As of PR #313, this source file always needs `-XTypeApplications`.
lehins
pushed a commit
that referenced
this pull request
Nov 28, 2022
As of PR #313, this source file always needs `-XTypeApplications`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This handles the comment in the original PR, some comments outputs of the audit by bcryptic, and some name changes in the tests.
We close #295 in favour of this PR due to inactivity for a while.