This repository has been archived by the owner on Feb 9, 2021. It is now read-only.
[#196] Interpret and validate delegation certs #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruhatch
force-pushed
the
ruhatch/interpret-delegation
branch
from
51156e9
to
69d02c8
Compare
dnadales
reviewed
Jan 15, 2019
| @@ -27,7 +27,7 @@ module Ledger.Delegation | |||
| , ADELEG | |||
| , ADELEGS | |||
| , initialDState | |||
| , DSEnv (DSEnv) | |||
| , DSEnv (..) | |||
There was a problem hiding this comment.
Why do we prefer to export things explicitly? My argument for using explicit exports is that we don't export things we don't want inadvertently.
dnadales
reviewed
Jan 15, 2019
| , testGroup | ||
| "Properties" | ||
| [ testProperty "Activation" dcertsAreTriggered | ||
| , testProperty "One delegation per-slot per-key" rejectDupSchedDelegs |
There was a problem hiding this comment.
One issue I see with this alignment is that we'll likely have to change two more lines if we add a third one :)
ruhatch
force-pushed
the
ruhatch/interpret-delegation
branch
from
69d02c8
to
33e302c
Compare
ruhatch
force-pushed
the
ruhatch/interpret-delegation
branch
from
33e302c
to
7fe4f88
Compare
|
bors r+ |
Build succeeded |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.