Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "query protocol parameters: use ledger instances" #475

Merged
merged 1 commit into from Nov 22, 2023

Conversation

carbolymer
Copy link
Contributor

@carbolymer carbolymer commented Nov 22, 2023

This reverts commit 450a0a6.

This reverts #455 which breaks round-tripping of protocol parameters.

Fixes #472 & #474

Changelog

- description: |
    Revert #455 - use custom serialization for protocol parameters.
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
   - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Additional context for the PR goes here. If the PR fixes a particular issue please provide a link to the issue.

How to trust this PR

Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@carbolymer carbolymer force-pushed the mgalazyn/fix/revert-use-ledger-pp-serialization branch from d42f586 to f19e983 Compare November 22, 2023 18:51
@carbolymer carbolymer force-pushed the mgalazyn/fix/revert-use-ledger-pp-serialization branch from f19e983 to 5b1c489 Compare November 22, 2023 18:52
@carbolymer carbolymer added this pull request to the merge queue Nov 22, 2023
Merged via the queue into main with commit ca5392f Nov 22, 2023
20 checks passed
@carbolymer carbolymer deleted the mgalazyn/fix/revert-use-ledger-pp-serialization branch November 22, 2023 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

transaction calculate-min-fee fails with missing extraPraosEntropy key
2 participants