Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Plutus V3 in command line interface #479

Merged
merged 1 commit into from
Nov 24, 2023

Conversation

carbolymer
Copy link
Contributor

Changelog

- description: |
    Add support for Plutus V3 in command line interface
# uncomment types applicable to the change:
  type:
   - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
   - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Additional context for the PR goes here. If the PR fixes a particular issue please provide a link to the issue.

How to trust this PR

Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

( Opt.long (prefix ++ "plutus-script-v2")
<> Opt.help "Specify a plutus script v2 reference script."
)
pPlutusScriptLanguage prefix = plutusP PlutusScriptV2 "v2" <|> plutusP PlutusScriptV3 "v3"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we still support v2 here?

Copy link
Contributor

@Jimbo4350 Jimbo4350 Nov 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes and we should technically still support PlutusScriptV1 as well. I'm not sure when or why that was dropped because all versions of plutus scripts have to work on mainnet.

Copy link
Contributor

@Jimbo4350 Jimbo4350 Nov 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you find out internally if we should eventually be deprecating V2 from the cli? We already no longer support V1 in the cli and it's not clear how we should approach this.

Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@carbolymer carbolymer added this pull request to the merge queue Nov 24, 2023
Merged via the queue into main with commit 66d2cf6 Nov 24, 2023
20 checks passed
@carbolymer carbolymer deleted the mgalazyn/feature/add-support-for-plutus-v3 branch November 24, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants