Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#86 Set default era to Babbage in stake-address, stake-pool and governance commmands #90

Merged
merged 2 commits into from
Jul 20, 2023

Conversation

carbolymer
Copy link
Contributor

@carbolymer carbolymer commented Jul 19, 2023

Changelog

- description: |
    Set default era to Babbage in stake-address, stake-pool and governance commmands
  # no-changes: the API has not changed
  # compatible: the API has changed but is non-breaking
  # breaking: the API has changed in a breaking way
  compatibility: compatible
  # feature: the change implements a new feature in the API
  # bugfix: the change fixes a bug in the API
  # test: the change fixes modifies tests
  # maintenance: the change involves something other than the API
  # If more than one is applicable, it may be put into a list.
  type: feature

Context

Closes #86

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • The change log section in the PR description has been filled in
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • The changelog section in the PR is updated to describe the change
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

@carbolymer carbolymer force-pushed the mgalazyn/feat/use-default-era-common-parser branch from d7c4b73 to be6eeda Compare July 19, 2023 14:32
@carbolymer carbolymer force-pushed the mgalazyn/feat/use-default-era-common-parser branch 3 times, most recently from 2e31954 to 6e37772 Compare July 19, 2023 16:34
@carbolymer carbolymer requested review from a team as code owners July 19, 2023 16:34
@carbolymer carbolymer added this pull request to the merge queue Jul 20, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Jul 20, 2023
@carbolymer carbolymer force-pushed the mgalazyn/feat/use-default-era-common-parser branch from a2c91be to 2cb249d Compare July 20, 2023 08:52
@carbolymer carbolymer force-pushed the mgalazyn/feat/use-default-era-common-parser branch from 2cb249d to 0739e4a Compare July 20, 2023 09:19
Copy link
Contributor

@mkoura mkoura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regression tests passed.

@carbolymer carbolymer added this pull request to the merge queue Jul 20, 2023
Merged via the queue into main with commit 42d5ecd Jul 20, 2023
17 checks passed
@carbolymer carbolymer deleted the mgalazyn/feat/use-default-era-common-parser branch July 20, 2023 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLI commands that create certificates now need an era argument
3 participants