Might now work for Shelley (Byron unchanged) #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksaric
reviewed
Jun 3, 2020
| At blk -> Just (SlotNumber . unSlotNo $ Point.blockPointSlot blk, Point.blockPointHash blk) | ||
|
|
||
| renderHash :: ShelleyHash -> Text | ||
| renderHash = const "renderHash" |
There was a problem hiding this comment.
Should be:
renderHash :: ShelleyHash -> Text
renderHash = Text.decodeUtf8 . unHeaderHash
ksaric
approved these changes
Jun 3, 2020
| data DbAction | ||
| = DbApplyBlock !CardanoBlockTip | ||
| | DbRollBackToPoint !CardanoPoint | ||
| | DbFinish |
There was a problem hiding this comment.
What is this for? "End of the world" scenario?
There was a problem hiding this comment.
It has been there for ages. It can probably be removed at some point, but I won't do it now because simple Shelley support and then full Shelly support is a priority,
| { dbActQueue :: TBQueue DbAction | ||
| } | ||
|
|
||
| class MkDbAction blk where |
There was a problem hiding this comment.
Nice, but I think the consensus guys are doing something pretty similar with the abstractions.
There was a problem hiding this comment.
Sorry, I do not think that is nice.
|
|
||
| import qualified Shelley.Spec.Ledger.BlockChain as Shelley | ||
| import qualified Shelley.Spec.Ledger.Tx as Shelley | ||
| -- import qualified Shelley.Spec.Ledger.TxData as Shelley |
Byron has been tested and there is very unlikely to be breakage. Shelley has been minimally tested and there are likely to be bugs. Some of the Shelley code in lower level libraries is not even complete yet, for instance: * Address hashes are currently 32 bytes and should be 28 bytes. * Address encoding is Base16 but is supposed to be bech32. * Need a way to generate a Genesis Hash for a pure Shelley chain.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.