Test restarting db-sync with alternate command line params #1466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cmdv
force-pushed
the
tests-stop-start-cmd-line
branch
2 times, most recently
from
209cc82
to
00fd409
Compare
Cmdv
force-pushed
the
tests-stop-start-cmd-line
branch
4 times, most recently
from
4f3b562
to
950b92a
Compare
Cmdv
force-pushed
the
tests-stop-start-cmd-line
branch
from
1b55527
to
8417f1d
Compare
Cmdv
force-pushed
the
tests-stop-start-cmd-line
branch
from
81c1e5b
to
8a37938
Compare
kderme
requested changes
Aug 25, 2023
cardano-chain-gen/test/Test/Cardano/Db/Mock/Unit/Babbage/CommandLineArg/ForceIndex.hs
Outdated
Show resolved
Hide resolved
cardano-chain-gen/test/Test/Cardano/Db/Mock/Unit/Babbage/CommandLineArg/ForceIndex.hs
Outdated
Show resolved
Hide resolved
cardano-db/src/Cardano/Db/Migration/Extra/CosnumedTxOut/Queries.hs
Outdated
Show resolved
Hide resolved
kderme
requested changes
Aug 31, 2023
Cmdv
force-pushed
the
tests-stop-start-cmd-line
branch
from
3a7326e
to
c5e8706
Compare
kderme
approved these changes
Sep 5, 2023
| wasPruneTxOutPreviouslySet = elem PruneTxOutFlagPreviouslySet | ||
|
|
||
| data PruneConsumeMigration = PruneConsumeMigration | ||
| { pcmConsume :: Bool |
There was a problem hiding this comment.
Is this ever used? Maybe it can be removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes:
#1465
#1486
Checklist
fourmoluon version 0.10.1.0 (which can be run withscripts/fourmolize.sh)Migrations
If there is a breaking change, especially a big one, please add a justification here. Please elaborate
more what the migration achieves, what it cannot achieve or why a migration is not possible.