Bump dependencies #495
Merged
Bump dependencies #495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kderme
force-pushed
the
kderme/bump
branch
2 times, most recently
from
5193a25
to
b5f9a76
Compare
erikd
reviewed
Jan 20, 2021
| versionErrorMsg = Text.concat | ||
| [ Text.pack $ show version | ||
| , " is not enough. We need at least " | ||
| , Text.pack $ show minVersion ] |
There was a problem hiding this comment.
Closing ] on the next line under the comma to match the rest of the code.
erikd
reviewed
Jan 20, 2021
| @@ -15,10 +15,10 @@ import Cardano.Chain.Common (CompactAddress, Lovelace, decodeAddressBa | |||
| toCompactAddress, unsafeGetLovelace) | |||
| import qualified Cardano.Chain.UTxO as Byron | |||
|
|
|||
| import qualified Cardano.Ledger.Core as Core | |||
There was a problem hiding this comment.
The qualified imports in this project are far from optimal and I have been meaning to fix them.
As a start in the right direction, can we import that as Ledger ?
erikd
reviewed
Jan 20, 2021
| :: forall era. ShelleyBased era | ||
| => Text -> Shelley.UTxO era -> Either Text Word64 | ||
| getShelleyBalance :: forall era. | ||
| ( Core.TxOut era ~ Shelley.TxOut era -- somewhere in ledger-spec, there is probably a better constraint synonym for these |
There was a problem hiding this comment.
Can you try to match the formatting?
I wish I had a tool that could enforce formatting in a way that is not horrible, I hate brittany and ormul??? or whatever its called.
dcoutts
reviewed
Jan 20, 2021
Comment on lines
+269
to
+276
| versionErrorMsg :: Text | ||
| versionErrorMsg = Text.concat | ||
| [ "The cardano-node version is too old. Please upgrade to a compatible " | ||
| , "cardano-node version. The db-sync requires a node that supports " | ||
| , textShow minVersion | ||
| , ", the one in use only supports " | ||
| , textShow version | ||
| ] |
The dependency bump also includes update to the way the history interpreter is acquired and that in turn requires NodeToClientV_8. A nice error message has been added if this version requirement is not met.
This logic remains from the earliest versions of db-sync, and even
pre-dates the OBFT version of Byron. It is no longer relevant for
Shelley and later.
From memory this code was added to handle rollbacks across epoch
boundaries (pre-OBFT we had Epoch Boundary Blocks) but since there
are no new EBBs (the old ones are still part of the chain), we can
no longer have a rollback across an epoch boundary with an EBB
involved. This code was also a involved in a mis-sync:
#496
Not sure how the above happened and not able to reproduce it.
However, since this is pre-OBFT and Byron specific this code can
simply be removed. The worst that can happen is that there is still
a undiscovered bug, but at least the problem should be more
obvious with this code removed.
Closes: #496
Doing this means that when syncing the "db_tip_height" metric will increment by this new value instead of incrementing by 2000 as it was previously. The new value makes the metric easier to eyeball for changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main changes: