Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add info about faucet's required pool id format - bech32 #510

Merged

Conversation

ArturWieczorek
Copy link
Contributor

@ArturWieczorek ArturWieczorek commented Jun 20, 2023

When using faucet to delegate funds to pool and entering pool ID in hex format - 3ad683d9d9f38f43c1b638f0e79f1c91173d324c0c3055971aacf575 there is an error.

Request Method: GET
Status Code:400

Request URL:
https://faucet.preview.world.dev.cardano.org/delegate?poolid=3ad683d9d9f38f43c1b638f0e79f1c91173d324c0c3055971aacf575&api_key=&g-recaptcha-response=03AL8dmw-05XFCq0ZZlmR9qg_mIVsjEXrNlxC3VmSAgy8BgEPKXOzrC6tQLaRclR8qPlzfuDXveWykFGJwMG36ogKt0dvmYoYOgClUzsmLR-XU-W6KHDBvXywLgEzZDjkMYCKBADt7_Ddg-VjdKvgliZA26Hs-XhQZ75Y3S29NAY51dhNV6hxZPcTh0r-JxfwxAyNa--1cU31vhrZAdAxhVi9xMCyASbr3lC82XYQRYkDezI1-HRxWqJmHFDE34lzCI6hDpiP7NK0bbi8Yebo5YQDDyfSTA_LFYY1QHYyrGJIh-CUDGEj8JdeVJpnYQMoejWQhUm5Cq7zQkOMBuR1in_APnc7uaySXXyV7F8P5IIYfqYX-eQECE7aRa-HpOWa-wOErKlmMQwGSGrXnXV-kAQi512XZ3qom76ZexMk17ud42c0ofeX5l2XBEOYdjSNFEjYF-KNSuSoaiU4fDPcZdLDmW3jUGD6x0ylLj9HnOQg9NQFR-3eMSjinN6wLyLhWnCoJnB-TRsohe5LkoJin_lMJvMD9QEsbBF9NkAXv-U1KxIr69wAAUmQ

This error however is not present when using bech32 format for pool ID - e.g. pool18ttg8kwe7w858sdk8rcw08cujytn6vjvpsc9t9c64n6h27wza2u.

I ran into this issue when trying to delegate funds to my test pool.
This PR updates documentation and aims to avoid confusion.

There is an enhancement ticket that is supposed to fix it and support two formats in the future: IntersectMBO/cardano-world#95

Original slack thread here: https://input-output-rnd.slack.com/archives/C03NYMJBD7F/p1687265266352119

@netlify
Copy link

netlify bot commented Jun 20, 2023

👷 Deploy request for magenta-clafoutis-3ca66e pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 11db625

Copy link

@CarlosLopezDeLara CarlosLopezDeLara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@NeilBurgess42 NeilBurgess42 self-assigned this Jun 22, 2023
@NeilBurgess42
Copy link
Collaborator

@CarlosLopezDeLara has approved, that is good enough for me.

@NeilBurgess42 NeilBurgess42 merged commit 8f51443 into input-output-hk:master Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants