Skip to content

Commit

Permalink
fixup! fix(wallet)!: store keeps track of in flight transactions
Browse files Browse the repository at this point in the history
Remove resolved comment.
Remove subscribe expectation because it is already performed by other tests
  • Loading branch information
mirceahasegan committed Jun 21, 2022
1 parent 73d0ff1 commit 4d4baf5
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions packages/wallet/test/services/TransactionsTracker.test.ts
Expand Up @@ -267,7 +267,6 @@ describe('TransactionsTracker', () => {

expectObservable(transactionsTracker.outgoing.pending$).toBe('|');
expectObservable(transactionsTracker.outgoing.confirmed$).toBe('--|');
// check confirmed transaction works when history contains the stored inFlight tx
expectObservable(transactionsTracker.outgoing.failed$).toBe('--|');

expectObservable(transactionsTracker.outgoing.submitting$).toBe('ab|', {
Expand Down Expand Up @@ -305,7 +304,7 @@ describe('TransactionsTracker', () => {
b: [incomingTx],
c: [incomingTx, outgoingTx]
});
const confirmedSubscription = '--^--'; // regression: subscribing after submitting$ emits

const transactionsTracker = createTransactionsTracker(
{
addresses$,
Expand All @@ -325,7 +324,7 @@ describe('TransactionsTracker', () => {
}
);
expectObservable(transactionsTracker.outgoing.submitting$).toBe('a---|', { a: inFlightTransaction });
expectObservable(transactionsTracker.outgoing.confirmed$, confirmedSubscription).toBe('---a|', {
expectObservable(transactionsTracker.outgoing.confirmed$).toBe('---a|', {
a: inFlightTransaction
});
expectObservable(transactionsTracker.outgoing.inFlight$).toBe('a--b|', {
Expand Down

0 comments on commit 4d4baf5

Please sign in to comment.