Merge pull request #1249 from input-output-hk/fix/empty-fuzzy-search

fix(cardano-services): stake pool fuzzy search empty result
input-output-hk · May 7, 2024 · 6b7dd94 · 6b7dd94
2 parents b4abf94 + aff2cdd
commit 6b7dd94
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/packages/cardano-services/src/StakePool/TypeormStakePoolProvider/TypeormStakePoolProvider.ts b/packages/cardano-services/src/StakePool/TypeormStakePoolProvider/TypeormStakePoolProvider.ts
@@ -198,7 +198,7 @@ export class TypeormStakePoolProvider extends TypeormProvider implements StakePo
             [
               'DROP TABLE IF EXISTS tmp_fuzzy',
               'CREATE TEMPORARY TABLE tmp_fuzzy (pool_id VARCHAR, score NUMERIC) WITHOUT OIDS',
-              `INSERT INTO tmp_fuzzy VALUES ${values}`
+              ...(values === '' ? [] : [`INSERT INTO tmp_fuzzy VALUES ${values}`])
             ].join(';')
           );
         }

diff --git a/...cardano-services/test/StakePool/TypeormStakePoolProvider/TypeormStakePoolProvider.test.ts b/...cardano-services/test/StakePool/TypeormStakePoolProvider/TypeormStakePoolProvider.test.ts
@@ -646,6 +646,14 @@ describe('TypeormStakePoolProvider', () => {
             });
             expect(response.pageResults.map(({ metadata }) => metadata?.ticker)).toEqual(['SP11', 'SP10', 'SP1']);
           });
+
+          it('returns an empty array on empty search result', async () => {
+            const response = await provider.queryStakePools({
+              filters: { text: 'no one match this search' },
+              pagination
+            });
+            expect(response.pageResults).toEqual([]);
+          });
         });
 
         describe('stake pools sort', () => {