Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Number of predicates stated doesn't match number of predicates listed #1765

Closed
nankeen opened this issue Aug 7, 2020 · 0 comments · Fixed by #1773
Closed

Number of predicates stated doesn't match number of predicates listed #1765

nankeen opened this issue Aug 7, 2020 · 0 comments · Fixed by #1773

Comments

@nankeen
Copy link

nankeen commented Aug 7, 2020

Formal specification indicates that there are 8 predicate failures for UTXOW transition but only 7 are listed in the item list following that statement.

The LaTeX section has a TODO for “add multi-sig script failure predicates” so I assume this is the missing predicate. (?)

https://github.com/input-output-hk/cardano-ledger-specs/blob/master/shelley/chain-and-ledger/formal-spec/utxo.tex#L579

In addition, BadMetaDataHash is not in the executable spec, instead there are MissingTxBodyMetaDataHash, MissingTxMetaData, and ConflictingMetaDataHash which aren't in the formal spec.

@dcoutts dcoutts added the audit label Aug 7, 2020
@JaredCorduan JaredCorduan self-assigned this Aug 8, 2020
JaredCorduan pushed a commit that referenced this issue Aug 11, 2020
JaredCorduan pushed a commit that referenced this issue Aug 11, 2020
JaredCorduan pushed a commit that referenced this issue Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants