Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export PredicateFailure from all STS modules #1375

Merged
merged 1 commit into from
Apr 16, 2020

Conversation

dcoutts
Copy link
Contributor

@dcoutts dcoutts commented Apr 16, 2020

We need access to the constructors of all the failures so that we can render them as errors in the log files.

The PredicateFailure for some STS rules have no constructors of course but for uniformity we just export them from every module.

Copy link
Contributor

@JaredCorduan JaredCorduan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

We need access to the constructors of all the failures so that we can
render them as errors in the log files.

The PredicateFailure for some STS rules have no constructors of course
but for uniformity we just export them from every module.
@JaredCorduan JaredCorduan force-pushed the dcoutts/export-predicatefailures branch from e72aaab to a51a348 Compare April 16, 2020 02:22
@JaredCorduan JaredCorduan merged commit b0f4b02 into master Apr 16, 2020
@iohk-bors iohk-bors bot deleted the dcoutts/export-predicatefailures branch April 16, 2020 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants