some better UTXOW errors #1458
some better UTXOW errors #1458
Conversation
| Bool | ||
| verifiedWits (Tx txbody wits _ _) = | ||
| all (verifyWitVKey $ hashWithSerialiser toCBOR txbody) wits | ||
| [VKey 'Witness crypto] |
There was a problem hiding this comment.
This is very confusing! The function verifiedWits returns the list of witnesses that didn't verify?
In such a case, I think it's better to use Either [VKey 'Witness crypto] () (or at least a heavy comment flagging the unexpected behaviour!)
There was a problem hiding this comment.
yes, thank you, that's way better
| @@ -160,10 +171,11 @@ utxoWitnessed = | |||
| ?! MissingScriptWitnessesUTXOW | |||
|
|
|||
| -- check VKey witnesses | |||
| verifiedWits tx ?! InvalidWitnessesUTXOW | |||
| let failedWits = verifiedWits tx | |||
| failedWits == mempty ?! InvalidWitnessesUTXOW failedWits | |||
There was a problem hiding this comment.
Note that Either [..] () will let you use ?!: :-D
There was a problem hiding this comment.
it's like Christmas in May! 🎄
There was a problem hiding this comment.
(seriously, that's great)
|
|
||
| let needed = witsVKeyNeeded utxo tx genDelegs | ||
| needed `Set.isSubsetOf` witsKeyHashes ?! MissingVKeyWitnessesUTXOW | ||
| needed `Set.isSubsetOf` witsKeyHashes ?! MissingVKeyWitnessesUTXOW (needed `Set.difference` witsKeyHashes) |
There was a problem hiding this comment.
I guess this operation is on small enough sets that we don't care too much about repeating work
There was a problem hiding this comment.
yea, I thought it read nicer without the let binding, and that the extra work in the error case was fine. but maybe that's silly.
|
Thanks @JaredCorduan |
This PR adds better errors for
InvalidWitnessesUTXOWandMissingVKeyWitnessesUTXOW.I hope to be able to add robust error types for all the ledger failures in the near future. But please let me know if there are certain failures that you would like me to prioritize.
closes #1456