Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose PrtlSeqFailure's constructors and improve its errors #1463

Merged
merged 1 commit into from May 19, 2020
Merged

Expose PrtlSeqFailure's constructors and improve its errors #1463

merged 1 commit into from May 19, 2020

Conversation

Jimbo4350
Copy link
Contributor

No description provided.

@Jimbo4350 Jimbo4350 force-pushed the jordan/expose-prtlseqfailure-constructors branch 2 times, most recently from 577d4ec to e4df587 Compare May 19, 2020 08:41
dcoutts
dcoutts approved these changes May 19, 2020
View reviewed changes
Copy link
Contributor

@dcoutts dcoutts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

JaredCorduan
JaredCorduan approved these changes May 19, 2020
View reviewed changes
Copy link
Contributor

@JaredCorduan JaredCorduan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@nc6
Copy link
Contributor

nc6 commented May 19, 2020

What, why? How does cardano-node need these? The CHAIN STS is used only for testing, it isn't called from consensus (which implements its own checks to do these things) - there should be no need for these things in cardano-node.

nc6
nc6 previously requested changes May 19, 2020
View reviewed changes
Copy link
Contributor

@nc6 nc6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The improved errors are good, but hitting 'request changes' on this until it's clear why this is needed in cardano-node

@Jimbo4350 Jimbo4350 force-pushed the jordan/expose-prtlseqfailure-constructors branch from e4df587 to 459b6d4 Compare May 19, 2020 10:42
@Jimbo4350 Jimbo4350 requested a review from nc6 May 19, 2020 10:45
@Jimbo4350 Jimbo4350 dismissed nc6’s stale review May 19, 2020 10:50

As per slack discussion the consensus is to merge

@Jimbo4350
Copy link
Contributor Author

bors merge

@iohk-bors
Copy link
Contributor

iohk-bors bot commented May 19, 2020

Build succeeded

@iohk-bors iohk-bors bot merged commit 584119e into master May 19, 2020
@iohk-bors iohk-bors bot deleted the jordan/expose-prtlseqfailure-constructors branch May 19, 2020 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaredCorduan JaredCorduan JaredCorduan approved these changes

@dcoutts dcoutts dcoutts approved these changes

@uroboros uroboros Awaiting requested review from uroboros

@nc6 nc6 Awaiting requested review from nc6

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Jimbo4350 @nc6 @JaredCorduan @dcoutts