add VRF keyhashes to genesis delegation mapping #1501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and check the VRF values for overlay slots
JaredCorduan
force-pushed
the
jc/spec/pbft-vrf-checks
branch
from
689a697
to
70f2b4d
Compare
nc6
approved these changes
May 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR updates the formal spec with the changes made in #1495 .
Previously, genesis key delegation certificates only registered the delegate cold key. Now the Genesis delegation certificates also register a VRF key, and the resulting genesis delegation map maps genesis keyhashes to pairs of cold keyhashes and vrf keyhashes.
Moreover, we now check 1) that the VRF key in the block header is the registered one, 2) the two VRF values (nonce and leader) validate against the VRF certificate in the block header.