Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix hash documentation (28 vs 32 bytes) #1622

Merged
merged 2 commits into from Jul 7, 2020
Merged

fix hash documentation (28 vs 32 bytes) #1622

merged 2 commits into from Jul 7, 2020

Conversation

JaredCorduan
Copy link
Contributor

closes #1588

@JaredCorduan JaredCorduan requested review from uroboros and nc6 July 7, 2020 13:54
@JaredCorduan
Copy link
Contributor Author

this PR triggered a property test failure which turned out to be caused by a hash conflict (in testing we use a short hash that has only four bytes). we generated two different transactions with the same ID, which then destroyed a UTxO. I've added a commit to this PR that just adds some better logging to this test failure.

@JaredCorduan JaredCorduan merged commit f8fd7ed into master Jul 7, 2020
@iohk-bors iohk-bors bot deleted the jc/fix-hash-documentation branch July 7, 2020 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@redxaxder redxaxder redxaxder approved these changes

@uroboros uroboros Awaiting requested review from uroboros

@nc6 nc6 Awaiting requested review from nc6

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@JaredCorduan @redxaxder