Start optimising the memory footprint of the UTxO. #1663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since we rely on the (de)serialiseAddress then we should inherit the round trip property, but it's worth adding a QC test anyway. |
kantp
force-pushed
the
philipp/memory-opt
branch
2 times, most recently
from
ca8b5ba
to
cb967d5
Compare
added 7 commits
July 15, 2020 17:51
This changes the memory representation of TxIn and TxOut, to reduce overhead. In particular, we use unpacked Word64 for coin values and txout indices, and use the serialisation of addresses as ShortByteString. This does not yet change the representation of TxId. The changes are nearly opaque, in that we provide view patterns that takes the place of the old constructors. We do need to add a Crypto constraint wherever we use a TxOut, however, since the view pattern relies on serialisation/deserialisation.
Previously, we had relied on Generic, which was using the CompactUTxO construnctor directly (so the bytestring which was supposed to be a serialised address was just a random bystestring).
JaredCorduan
force-pushed
the
philipp/memory-opt
branch
from
d4e9afc
to
6aeb5a8
Compare
dcoutts
approved these changes
Jul 15, 2020
shelley/chain-and-ledger/executable-spec/src/Shelley/Spec/Ledger/TxData.hs
Outdated
Show resolved
Hide resolved
| pattern TxIn :: | ||
| Crypto crypto => | ||
| TxId crypto -> | ||
| Natural -> -- TODO We might want to change this to Word64 generally |
Co-authored-by: Duncan Coutts <duncan@well-typed.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the memory representation of TxIn and TxOut, to reduce overhead.
In particular, we use unpacked Word64 for coin values and txout indices, and use
the serialisation of addresses as ShortByteString.
This does not yet change the representation of TxId.
The changes are nearly opaque, in that we provide view patterns that takes the
place of the old constructors. We do need to add a Crypto constraint wherever we
use a TxOut, however, since the view pattern relies on
serialisation/deserialisation.
This is a draft PR for now, as I'd like to add some properties around the TxOut (I've introduced a
panicwhen deserialisation fails in the view pattern, which should never occur, since the constructor itself is not exported, and so the only way to construct a TxOut is using serialisation).