Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Further memory optimisation. #1678

Merged
merged 6 commits into from Jul 17, 2020
Merged

Further memory optimisation. #1678

merged 6 commits into from Jul 17, 2020

Conversation

kantp
Copy link
Contributor

@kantp kantp commented Jul 16, 2020

No description provided.

Philipp Kant added 2 commits July 16, 2020 11:34
Explicitly UNPACK hashes in Credential.
b7c3672 
GHC should do this anyway, but let's do it explicitly to be sure.
Another memory optimisation in the ledger state.
33e4ffa 
We do not keep the network identifier in every reward accoount.
@kantp kantp requested a review from uroboros as a code owner July 16, 2020 16:22
Philipp Kant and others added 3 commits July 16, 2020 21:32
ormolu
3ae45c6 
Those are changes in parts of the files I had not modified, so I did not include
them in the last commit, so as not to distract during the review.
adding a nework ID check for reward withdrawals
de3114c 
which is now neccessary since the reward mapping
does not have the IDs in them.
ormolu
bef4ac9
JaredCorduan
JaredCorduan approved these changes Jul 16, 2020
View reviewed changes
Copy link
Contributor

@JaredCorduan JaredCorduan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @kantp ! This is going to make #1520 very easy!

@kantp
Copy link
Contributor Author

kantp commented Jul 16, 2020

Great!

@JaredCorduan
Copy link
Contributor

mac-mini-1 strikes again, let me re-kick hydra

@JaredCorduan JaredCorduan merged commit 8716e38 into master Jul 17, 2020
@iohk-bors iohk-bors bot deleted the philipp/memory-opt branch July 17, 2020 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaredCorduan JaredCorduan JaredCorduan approved these changes

@dcoutts dcoutts Awaiting requested review from dcoutts

@uroboros uroboros Awaiting requested review from uroboros

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kantp @JaredCorduan