use current data when calculating nonmyopic rewards #1724
Conversation
iohk-bors
bot
deleted the
use-current-pool-data-for-nonmyopic-information
branch
There was a problem hiding this comment.
I have reviewed this code as a possible patch for 1.18.0, so I am looking at this from the perspective of what possible impacts there could be on a stable version (rather than the usual "does the code do what it says on the tin").
Summary: This is LOW RISK for deployment.
The code doesn't impact core functionality, so would be low risk as a patch. It is not least risk (e.g. changing a constant or calculation).
Lines 33-38 add new imports
Line 57: the Crypto class is probably extraneous (shouldn't change any existing functionality)
Lines 81 and 86 are new calls, which could add execution costs [they are apparently maps of some kind so there is potential for this to be significant] and perhaps add some risk of non-termination/failure.
The other main changes are essentially to lookup operations (EpochBoundary/EB). I haven't traced these down but they should have a low probability of changing functionality or performance characteristics.
Any performance changes should be localised. The code is only executed on demand when the wallet queries it, so wallet testing should identify any issues here.
No description provided.