adding missing DELEG predicate failures to spec #1725
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The formal spec listed only 7 predicate failures for the DELEG rule, but the implementation contained 11 (which did include the 7).
StakeKeyInRewards
should actually be removed. It is redundant withStakeKeyAlreadyRegistered
(we removed thestkCreds
mapping from the implementation in removestkcreds
andstpools
#1683 and from the spec in Remove the now irrelevant mapsstkCreds
andstpools
from the formal spec #1692, making the reward mapping the source of truth for registered stake credentials). Unfortunately, we are usingStakeKeyInRewards
in the place whereStakeKeyAlreadyRegistered
is the more helpful name. I have made a TODO in the implementation to replaceStakeKeyInRewards
withStakeKeyAlreadyRegistered
when there is a good time (right now is not).StakeKeyNonZeroAccountBalance
,MIRCertificateTooLateInEpoch
, andDuplicateGenesisVRF
to the spec.closes #1719