Change the script hash algorithm to address hash #1746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaredCorduan
approved these changes
Aug 2, 2020
JaredCorduan
force-pushed
the
dcoutts/script-hash
branch
from
a041ed9
to
54e5927
Compare
nc6
approved these changes
Aug 3, 2020
|
Restarted the hydra build, failing on probabilistic checks |
This is preparation for changing the script hash type to use ADDRHASH rather than HASH. We change a few things that depend on it being specifically HASH. Redefine ScriptHash directly in terms of HASH, rather than indirectly in terms of the Hash type (which does also use HASH). We have to drop the HashAnnotated instance since it only supports HASH but we're about to switch to using ADDRHASH. We only use the instane in one place, so we just inline it there.
This compile-time test asserts that the script hash and key hash use the same hash size and indeed hash function. We do this by checking we can type-check the following code that converts between them by using the hash casting function which changes what the hash is of, without changing the hashing algorithm. This test fails at this stage with a type error, as it should, but will compile as of the next patch.
It ought to use the same hash function as keys, since we use them both in addresses and it's annoying if they're not the same, and the spec does call for them to be the same. This makes the compile-time test in the previous patch pass.
JaredCorduan
force-pushed
the
dcoutts/script-hash
branch
from
54e5927
to
28fd134
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the address hash algorithm rather than the normal hash algorithm,
to match the hash algorithm used in addresses for keys.