Addressing recent audit issues #1773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaredCorduan
force-pushed
the
jc/audit-2020-08-11
branch
from
468f0b3
to
32ada71
Compare
JaredCorduan
force-pushed
the
jc/audit-2020-08-11
branch
from
32ada71
to
3330660
Compare
|
fyi @uroboros, I had to increase |
I think we might as well double it to 10 |
uroboros
reviewed
Aug 12, 2020
| @@ -134,5 +134,5 @@ defaultConstants = | |||
| maxTreasury = 10000000, | |||
| minReserves = 1000000, | |||
| maxReserves = 10000000, | |||
| genTxRetries = 5 | |||
| genTxRetries = 6 | |||
There was a problem hiding this comment.
Suggested change
| genTxRetries = 6 | |
| genTxRetries = 10 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses several recent audit issues, all concerned with syncing the formal spec to the implementation. No semantic changes are made. I always preferred to change the formal spec over the implementation, but in a few places it was better to change the implementation.
The changes to the implementation were:
createRUpdwas previously taking the epoch in the implementation but not the formal spec. It was only used to get the "global constant"slotsPerEpoch(the hard fork combinator can change this). Now both the spec and the implementation are passed this constant.closes #1728
closes #1745
closes #1748
closes #1751
closes #1752
closes #1753
closes #1764
closes #1765