Optimise DeserializeShort.substring #1786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrBliss
force-pushed
the
mrBliss/optimise-substring
branch
from
42f881c
to
ef371e0
Compare
TimSheard
approved these changes
Aug 16, 2020
|
Using cloneByteArray is exactly what was needed. This should speed up things considerably. I cannot speak to the version numbers the projects. Thanks for doing this. |
In my microbenchmark, this brings down the cost of deserialising a Shelley address in `viewCompactTxOut` from ~360ns to ~60ns. The `cloneByteArray` function was introduced in version 0.7.1.0 of the `primitive` package, so update the lower bound accordingly. I believe the old `primitive < 0.7` constraint in `cabal.project` was due to older versions of the `cborg` package having `>=0.5 && <0.7.1.0` as bounds for `primitive`, but `cborg-0.2.4.0` bumped the upper bound to 0.8. This will likely require similar changes to downstream repos.
mrBliss
force-pushed
the
mrBliss/optimise-substring
branch
from
ef371e0
to
5a11efb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my microbenchmark, this brings down the cost of deserialising a Shelley
address in
viewCompactTxOutfrom ~360ns to ~60ns.The
cloneByteArrayfunction was introduced in version 0.7.1.0 of theprimitivepackage, so update the lower bound accordingly.I believe the old
primitive < 0.7constraint incabal.projectwas due toolder versions of the
cborgpackage having>=0.5 && <0.7.1.0as bounds forprimitive, butcborg-0.2.4.0bumped the upper bound to 0.8.This will likely require similar changes to downstream repos.