Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce repudateChainDepState #1789

Merged
merged 1 commit into from
Aug 18, 2020
Merged

Introduce repudateChainDepState #1789

merged 1 commit into from
Aug 18, 2020

Conversation

nc6
Copy link
Contributor

@nc6 nc6 commented Aug 18, 2020

Used for IntersectMBO/ouroboros-network#2520

This allows the avoidance of expensive crypto checks during block
reapplication, and shoudl shave something like 60% of the time off of
block reapplication.

@nc6
Introduce repudateChainDepState
1a22deb 
Used for IntersectMBO/ouroboros-network#2520

This allows the avoidance of expensive crypto checks during block
reapplication, and shoudl shave something like 60% of the time off of
block reapplication.
@nc6 nc6 requested a review from mrBliss August 18, 2020 07:53
mrBliss
mrBliss approved these changes Aug 18, 2020
View reviewed changes
Copy link
Contributor

@mrBliss mrBliss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@mrBliss mrBliss mentioned this pull request Aug 18, 2020
Merged
dcoutts
dcoutts approved these changes Aug 18, 2020
View reviewed changes
Copy link
Contributor

@dcoutts dcoutts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Seems to be updateChainDepState with applySTS swapped for reapplySTS and then the knock-on type changes, leaving it as a pure function since it can no longer fail. So that's exactly as expected. Nice.

@nc6 nc6 merged commit 9591f2d into master Aug 18, 2020
@nc6 nc6 deleted the nc/reupdateChainDepState branch August 18, 2020 09:34
mrBliss added a commit to IntersectMBO/cardano-node that referenced this pull request Aug 18, 2020
@mrBliss
Update dependencies
7671f97 
This brings in:
IntersectMBO/cardano-ledger#1789
IntersectMBO/ouroboros-network#2521
which together reduce block revalidation (restoring the ledger) by roughly 60%.
@mrBliss mrBliss mentioned this pull request Aug 18, 2020
Merged
iohk-bors bot added a commit to IntersectMBO/cardano-node that referenced this pull request Aug 18, 2020
@iohk-bors @mrBliss
Merge #1717
9e06d6f 
1717: Update dependencies r=dcoutts a=mrBliss

This brings in:
IntersectMBO/cardano-ledger#1789
IntersectMBO/ouroboros-network#2521
which together reduce block revalidation (restoring the ledger) by roughly 60%.

Co-authored-by: Thomas Winant <thomas@well-typed.com>
@nc6 nc6 mentioned this pull request Aug 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrBliss mrBliss mrBliss approved these changes

@dcoutts dcoutts dcoutts approved these changes

@JaredCorduan JaredCorduan Awaiting requested review from JaredCorduan

@uroboros uroboros Awaiting requested review from uroboros

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nc6 @mrBliss @dcoutts