CAD-1906: Alonzo transactions and serialisation #2055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a test (and necessary infrastructure) for serialisation and deserialisation of Alonzo-era TxBody.
- Introduce the transaction type for Alonzo - Introduce serialisation code for transactions. Note that currently, the transaction serialisation does _not_ allow Shelley/Allegra/Mary era transactions to decode directly as Alonzo transactions. If we decide that we should do this, it should not be particularly difficult to allow this, but since we do not sign transactions directly, we may simply convert old to new transactions and know that the TxBody will still have the correct hash. - Add a round-trip test for Tx serialisation.
JaredCorduan
approved these changes
Dec 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds:
Also it fixes a bunch of warnings.