Mary minimal property tests #2088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 8, 2021 08:12
(fixes an occasional problem in the trace generation)
JaredCorduan
commented
Jan 8, 2021
| @@ -368,6 +373,7 @@ genNextDelta | |||
| draftSize = | |||
| sum | |||
| [ 5 :: Integer, -- safety net in case the coin or a list prefix rolls over into a larger encoding | |||
| 12 :: Integer, -- TODO the size calculation somehow needs extra buffer when minting tokens | |||
There was a problem hiding this comment.
I do not understand why this was needed, but this turned out to be the smallest change that I could make to get the fee calculation to cover the minimal fee.
uroboros
approved these changes
Jan 11, 2021
There was a problem hiding this comment.
nice! thanks @JaredCorduan - I'm having a look at improving runtimes for a subsequent PR
| genTxBody slot ins outs cert wdrl fee upd meta = do | ||
| validityInterval <- genValidityInterval slot | ||
| let mint = error "TODO @uroboros mint some Mary era tokens" | ||
| mint <- genMint | ||
| let outs' = addTokensToFirstOutput (mint) outs |
| genTxBody slot ins outs cert wdrl fee upd meta = do | ||
| validityInterval <- genValidityInterval slot | ||
| let mint = error "TODO @uroboros mint some Mary era tokens" | ||
| mint <- genMint |
There was a problem hiding this comment.
we can wrap genMint with a genMintWithScripts that produces the policy scripts present in it's generated token bundles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the minimal property tests for the Mary era to the nightly tests. I've added them to the nightly tests since they take about 12 minutes to run (locally for me) and I am worried that they might be flaky (despite a good bit of effort to make them solid).
Transactions in Mary will now sometimes mint from three different token bundles. Each token bundle handles asset names differently: one always uses the same asset name, one chooses from five asset names, and one (nearly) always uses new asset names. Each bundle has a trivial policy (meaning no signature required), which made hooking this up easier. Note that we do have unit tests demonstrating that using the minting field triggers the correct authorization checks.
I had some difficulty with fee calculation in the generators. If I generate too many tokens we start doing things like generating negative fees. I had to add a constant in the fee calculation that I honestly do not understand yet (I'll make a comment in this PR at the spot).
I also fixed a small problem with the
rufflefunction.