last moment reward aggregation #2117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 27, 2021 13:42
Rewards are now separated by whether they are memember or leader rewards, and by which pool the reward iss associated with (a reward account can get rewards from multiple pools). The rewards are now aggregated when applying a reward update instead of when creating a reward update.
JaredCorduan
commented
Feb 1, 2021
| in if Set.null withoutZeros | ||
| then Nothing | ||
| else Just withoutZeros | ||
| rewards' = Map.mapMaybe removeDegenerate potentialRewards |
There was a problem hiding this comment.
@nc6 I know we talked about alter, but I've convinced myself that mapMaybe works better. yea?
nc6
approved these changes
Feb 1, 2021
| NonMyopic crypto -> | ||
| Coin -> | ||
| Map (KeyHash 'StakePool crypto) Likelihood -> | ||
| NonMyopic crypto | ||
| updateNonMypopic nm rPot newLikelihoods = |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewards are now separated by whether they are member or leader rewards, and by which pool the reward is associated with (a reward account can get rewards from multiple pools). The rewards are now aggregated when applying a reward update instead of when creating a reward update. This should make it a lot easier for applications such as db-sync to be able to track reward provenance.