Adds Pulsing to reward calculation (second try) #2142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimSheard
force-pushed
the
jc-ts-pulse
branch
from
ab300bf
to
e00d862
Compare
nc6
reviewed
Feb 18, 2021
shelley/chain-and-ledger/executable-spec/src/Shelley/Spec/Ledger/LedgerState.hs
Outdated
Show resolved
Hide resolved
shelley/chain-and-ledger/executable-spec/src/Shelley/Spec/Ledger/LedgerState.hs
Outdated
Show resolved
Hide resolved
shelley/chain-and-ledger/executable-spec/src/Shelley/Spec/Ledger/LedgerState.hs
Outdated
Show resolved
Hide resolved
shelley/chain-and-ledger/executable-spec/src/Shelley/Spec/Ledger/LedgerState.hs
Outdated
Show resolved
Hide resolved
shelley/chain-and-ledger/executable-spec/src/Shelley/Spec/Ledger/LedgerState.hs
Outdated
Show resolved
Hide resolved
TimSheard
force-pushed
the
jc-ts-pulse
branch
from
4e735a3
to
69409d8
Compare
nc6
reviewed
Feb 22, 2021
TimSheard
force-pushed
the
jc-ts-pulse
branch
2 times, most recently
from
fb58587
to
2715b28
Compare
nc6
reviewed
Feb 23, 2021
| @@ -197,11 +236,12 @@ tests = | |||
| prop_roundtrip_LEDGER_PredicateFails, | |||
| testProperty "roundtrip Protocol State" prop_roundtrip_PrtclState, | |||
| testProperty "roundtrip Ledger State" prop_roundtrip_LedgerState, | |||
| testProperty "roundtrip NewEpoch State" prop_roundtrip_NewEpochState, | |||
| -- testProperty "roundtrip NewEpoch State" prop_roundtrip_NewEpochState, | |||
There was a problem hiding this comment.
Is there a reason this is still commented?
There was a problem hiding this comment.
I uncommented, it passed, so a squashed everything into one commit.
nc6
approved these changes
Feb 23, 2021
Added Data.Pulse to the semantics library, then Integrated pulsing into the reward calculation. Added prettyA and Arbitrary instances for the new data. Cleaned up Data.Coders and the Annotated combinators.
JaredCorduan
force-pushed
the
jc-ts-pulse
branch
from
8a1d266
to
51fd21b
Compare
This was referenced Mar 4, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a better version of PR #2125