remove exunits from txbody #2166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please either rebase or squash before committing. |
nc6
reviewed
Mar 4, 2021
| @@ -399,18 +401,24 @@ txsize :: Tx era -> Integer | |||
| txsize (TxConstr (Memo _ bytes)) = fromIntegral (SBS.length bytes) | |||
|
|
|||
| minfee :: | |||
| ( HasField "exunits" (Core.TxBody era) ExUnits | |||
| ( Era era, | |||
| ToCBOR (Core.AuxiliaryData era), | |||
There was a problem hiding this comment.
I don't see why we need this ToCBOR constraint. Where is it used?
There was a problem hiding this comment.
it was complaining about the lack of this constraint. I saw that it was also used somewhere else where txrdmrs appeared
There was a problem hiding this comment.
ill try taking it out
| where | ||
| a protparam = Coin (fromIntegral (_minfeeA protparam)) | ||
| b protparam = Coin (fromIntegral (_minfeeB protparam)) | ||
| totExunits = foldl (<>) mempty (snd $ unzip (Map.elems trd)) | ||
| trd = getField @"txrdmrs" txw | ||
| txw = getField @"wits" tx |
There was a problem hiding this comment.
Could just inline this in the previous line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ExUnitsfield in the body of the tx because they are already tracked in the indexed redeemer structure inside the witness section of the transactionadHashfrom the body because the body contained 2 hashes of auxiliary data, and only needs 1, and renamingscriptHash(the other aux. data hash) toauxdHashto match the order in the spec