Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump plutus and fix breaking changes #2411

Closed
wants to merge 1 commit into from
Closed

Bump plutus and fix breaking changes #2411

wants to merge 1 commit into from

Conversation

kk-hainq
Copy link
Contributor

@kk-hainq kk-hainq commented Aug 4, 2021

Mainly updating ByteString to BuiltinByteString.

Reference:

mainly updating ByteString to BuiltinByteString
@JaredCorduan
Copy link
Contributor

thank you for helping out @kk-hainq ! We actually already moved to BuiltinByteString (see #2407).

@kk-hainq
Copy link
Contributor Author

kk-hainq commented Aug 4, 2021

thank you for helping out @kk-hainq ! We actually already moved to BuiltinByteString (see #2407).

Oh, it's in plutus-staging! I think we can close this then, any idea when we can merge that one?

Also wonder if we can still force push to keep this one, for deleting the duplicate flat entry in cabal.project.

@JaredCorduan
Copy link
Contributor

Oh, it's in plutus-staging! I think we can close this then, any idea when we can merge that one?

Also wonder if we can still force push to keep this one, for deleting the duplicate flat entry in cabal.project.

I'm not sure, @michaelpj probably knows more, though.

I can put up a separate PR to remove the flat entry. I'd have to do that anyway, since our CI won't run on forks. (which is really unfortunate, see buildkite/feedback#293)

@kk-hainq
Copy link
Contributor Author

kk-hainq commented Aug 4, 2021

Oh, it's in plutus-staging! I think we can close this then, any idea when we can merge that one?
Also wonder if we can still force push to keep this one, for deleting the duplicate flat entry in cabal.project.

I'm not sure, @michaelpj probably knows more, though.

I can put up a separate PR to remove the flat entry. I'd have to do that anyway, since our CI won't run on forks. (which is really unfortunate, see buildkite/feedback#293)

Sure, thanks. I'll just close this for now then.

@kk-hainq kk-hainq closed this Aug 4, 2021
@michaelpj
Copy link
Contributor

The workflow is to merge plutus-staging regularly, although we haven't worked out a schedule yet (we're still working on this process...). I was planning to do it today.

@kk-hainq
Copy link
Contributor Author

kk-hainq commented Aug 5, 2021

The workflow is to merge plutus-staging regularly, although we haven't worked out a schedule yet (we're still working on this process...). I was planning to do it today.

Cardano has brought us so much opportunity that we've been wanting to contribute a lot back. Bumping dependency versions of key components when there are breaking changes is a good start, please tell us if we could help in any way.

We'd like to write more documentation, especially on Plutus and Smart Contracts too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants