Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor bugfixes #2563

Merged
merged 2 commits into from Nov 24, 2021
Merged

Minor bugfixes #2563

merged 2 commits into from Nov 24, 2021

Conversation

lehins
Copy link
Contributor

@lehins lehins commented Nov 24, 2021

This PR fixes two bugs:

  1. utxow property tests failed recently on CI: https://github.com/input-output-hk/cardano-ledger/runs/4311566920?check_suite_focus=true
    Reason is collateralPercentage was genrated to be 0, which caused the test to not generate any collateral, despite that it was required.
  • Deserialization of BiMap expects keys to be distinct and ordered. Ensure that this is indeed the case and produce deserialization error when it is violated.

@lehins lehins requested a review from nc6 November 24, 2021 19:39
nc6
nc6 approved these changes Nov 24, 2021
View reviewed changes
Copy link
Contributor

@nc6 nc6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nc6 nc6 merged commit 93c3dec into master Nov 24, 2021
@iohk-bors iohk-bors bot deleted the lehins/minor-bugfixes branch November 24, 2021 21:00
TimSheard added a commit that referenced this pull request Nov 29, 2021
@TimSheard
fixed a revertion of PRs: #2563
78ba9a7
TimSheard added a commit that referenced this pull request Nov 29, 2021
@TimSheard
Reorganized SetAlgebra by breaking it into 4 modules. (#2564)
ccaecc8 
* Reorganized SetAlgebra by breaking it into 4 modules. New ones are Control.Iterate.BaseTypes, Control.Iterate.Exp, and Control.Iterate.BiMap

* fixed a revertion of PRs: #2563
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nc6 nc6 nc6 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lehins @nc6