add MIR changes to Alonzo spec #2579
Conversation
| \label{fig:dcert-mir-trans} | ||
| \end{figure} | ||
|
|
||
| \begin{figure}[ht] |
There was a problem hiding this comment.
Not sure if it's worth it, but we could get rid of the code duplication in MIR by having a single rule for it and defining an acnt' to be either of the two options depending on the condition.
There was a problem hiding this comment.
that's true, as I mention in the comment above, that is actually how the code works.
There was a problem hiding this comment.
I forgot to attempt this after the first review, I've done it now, see what you think. It was a bit hard to keep the horizontal space within the table, but I think it looks okay-ish. :)
There was a problem hiding this comment.
I should probably make these "reduce copy" changes to the shelley spec as well now...
There was a problem hiding this comment.
ok, I've changed the Shelley MIR transitions as well now. The compare nicely now.
JaredCorduan
force-pushed
the
jc/alonzo-mir
branch
2 times, most recently
from
644d829
to
3f7569a
Compare
JaredCorduan
force-pushed
the
jc/alonzo-mir
branch
from
f1c4ce0
to
64b4475
Compare
|
I somehow broke the latex build, I will fix that tomorrow |
Re-wrote the Shelley MIR transitions to be more compact (in the style newly added to the Alonzo spec). Additionally, added a new check to the Alonzo MIR rule (implementation) that ensures that the Coin valued used in transfers (reserves <-> treasury) is always non-negative.
JaredCorduan
force-pushed
the
jc/alonzo-mir
branch
from
64b4475
to
156a135
Compare
Additionally, added a new check to the Alonzo MIR rule that ensures that the Coin valued used in transfers (reserves <-> treasury) is always non-negative. This does mean that the predicate serialization has changed, but as this is a governance feature we should be fine (cc @nc6).