Use splitmap for utxo #2592
Merged
Use splitmap for utxo #2592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lehins
force-pushed
the
lehins/use-splitmap-for-utxo
branch
from
1691f71
to
165a152
Compare
TimSheard
reviewed
Jan 3, 2022
There was a problem hiding this comment.
Every thing looks good. The set algebra function function (◁) where the value on the right is a SpitMap is use so many times. We should make a version ins SpitMap, and then use
(set Split.◁ splitmap) this maintains continuity with the spec and the older code.
eras/shelley/test-suite/src/Test/Cardano/Ledger/Shelley/Generator/Core.hs
Show resolved
Hide resolved
lehins
force-pushed
the
lehins/use-splitmap-for-utxo
branch
2 times, most recently
from
254688d
to
e75a132
Compare
JaredCorduan
approved these changes
Jan 6, 2022
There was a problem hiding this comment.
LGTM! I think it would be nice to make the special case domain restriction function like @TimSheard suggests.
lehins
force-pushed
the
lehins/use-splitmap-for-utxo
branch
4 times, most recently
from
ca58dfd
to
4b0f331
Compare
* Add missing instances for `KeyMap` and `SplitMap` * Add missing functions for `SplitMap` * Remove all `SplitMap` related stuff from set algebra * Add `NoThunks` instance * Identify and fix one normalization bug in KeyMap and another in SplitMap: * Add various annotations to tests for helping to identify causes of failure * Fix `Show` instance for `SplitMap` * Remove `InstanceSigs` in order to get rid of compilation warning * Add `Traversable` for `SplitMap` and slight optimization for `UTxO` generator * Implement specialized `extractKeysSet` and utilize it in the rules * Add comments that match the spec to a now different looking implementation * Switch `scriptsNeeded` to use list comprehensions for clarity * Tap into list fusion for `SplitMap` list conversions * Add `◁` for `SplitMap` * Improve performance of `balance` function and add some benchmarks for it
lehins
force-pushed
the
lehins/use-splitmap-for-utxo
branch
from
4b0f331
to
a5eea8d
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switches UTxO to
SplitMap, which is in itself is based on a nested data structureIntMapand customKeyMapthat is indexed by 32byte keys.