Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor improvements #2611

Merged
merged 9 commits into from Jan 13, 2022
Merged

Minor improvements #2611

merged 9 commits into from Jan 13, 2022

Conversation

lehins
Copy link
Contributor

@lehins lehins commented Jan 11, 2022

This is a tiny PR that adds some bangs on data types that seem to have them missing.

It also simplifies recently added code just a tiny bit.

Please ignore changes to benchmark suite, they aren't important.

Copy link
Contributor

@JaredCorduan JaredCorduan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lehins lehins force-pushed the lehins/bench-new-ledger-state branch 2 times, most recently from 3f1da26 to 9f771f6 Compare January 11, 2022 21:28
Copy link
Contributor

@TimSheard TimSheard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, Might want to give more descriptive names to the pseudo-projction functions that test if one of the fields in a Triple is Just or Nothing.

eras/shelley/test-suite/bench/Main.hs Show resolved Hide resolved
@lehins lehins force-pushed the lehins/bench-new-ledger-state branch from 9f771f6 to d6a8ecf Compare January 12, 2022 21:08
@lehins lehins merged commit 4d2ddab into master Jan 13, 2022
@iohk-bors iohk-bors bot deleted the lehins/bench-new-ledger-state branch January 13, 2022 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants