Ts tell rewards #2615
Merged
Ts tell rewards #2615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimSheard
force-pushed
the
ts-tell-rewards
branch
from
bcfa475
to
567d29d
Compare
|
looks great, just needs some tests |
TimSheard
force-pushed
the
ts-tell-rewards
branch
from
15b87b2
to
147ea6f
Compare
There was a problem hiding this comment.
Looks awesome @TimSheard ! I only had some trivial comments to add. Thanks for cleaning up the provenance! And I'm glad we kept the old total reward event too.
TimSheard
force-pushed
the
ts-tell-rewards
branch
from
d02a9b3
to
48a084f
Compare
…ses. This way there are many small reward events, rather than one big reward event. This is much more suitable for DB-Sync. Removed provenance from the reward pulser. Added the Trace operations GetEvents and splitTrace, and the Property forEachEpochTrace
TimSheard
force-pushed
the
ts-tell-rewards
branch
from
48a084f
to
3eb3684
Compare
nc6
reviewed
Jan 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have added incremental telling of reward updates. On every pulse we tell the member rewards we computed in that pulse. We still compute the accumulated rewards so that we can apply them to the LedgerState. But the telling should help the DB-Synch folks.
We maintain and test an invariant that the two ways of doing things compute the same result.
We develop a new testing framework to run property tests on Traces for a single epoch extracted from bigger traces.