remove subSlotCount function #2621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lehins
requested changes
Jan 20, 2022
eras/byron/ledger/impl/src/Cardano/Chain/Slotting/SlotNumber.hs
Outdated
Show resolved
Hide resolved
eras/byron/ledger/impl/src/Cardano/Chain/Update/Validation/Endorsement.hs
Show resolved
Hide resolved
lehins
approved these changes
Jan 20, 2022
JaredCorduan
force-pushed
the
jc/remove_subSlotCount
branch
2 times, most recently
from
f94f601
to
a091591
Compare
|
ha ha, fun failure :) |
This function is dangerous and could be replaced by addSlotCount everywhere in the consensus and ledger repositories.
JaredCorduan
force-pushed
the
jc/remove_subSlotCount
branch
from
a091591
to
18468a3
Compare
JaredCorduan
commented
Jan 21, 2022
| addSlotCount sc fs | ||
| === if unSlotNumber fs <= maxBound - (unSlotCount sc) | ||
| then added | ||
| else SlotNumber maxBound |
There was a problem hiding this comment.
this test feels pretty silly, it's the same logic as the function it is testing... and in general I feel like addSlotCount is only a bit less of a footgun than subSlotCount (the ordering on subSlotCount was pretty wacky).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
subSlotCountfunction is dangerous and can be replaced byaddSlotCounteverywhere in the consensus and ledger repositories.closes #1698