JSON instance for AlonzoGenesis #2627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taken from cardano-node closes #2452
JaredCorduan
commented
Jan 21, 2022
JaredCorduan
commented
Jan 21, 2022
| parseJSON = Aeson.withObject "Alonzo Genesis" $ \o -> do | ||
| coinsPerUTxOWord <- | ||
| o .: "lovelacePerUTxOWord" | ||
| <|> o .: "adaPerUTxOWord" --TODO: deprecate |
There was a problem hiding this comment.
@Jimbo4350 - should I remove adaPerUTxOWord?
There was a problem hiding this comment.
Yeah it looks like we can remove this, there is no trace of it in the node repo.
Jimbo4350
approved these changes
Jan 24, 2022
| parseJSON = Aeson.withObject "Alonzo Genesis" $ \o -> do | ||
| coinsPerUTxOWord <- | ||
| o .: "lovelacePerUTxOWord" | ||
| <|> o .: "adaPerUTxOWord" --TODO: deprecate |
There was a problem hiding this comment.
Yeah it looks like we can remove this, there is no trace of it in the node repo.
|
oh embarrassing, I forgot to smash the commits 🤦 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
taken from cardano-node
closes #2452